On 06/22/2016 02:48 PM, Pádraig Brady wrote: > On 22/06/16 13:18, Bernhard Voelker wrote: >> Unfortunately, it seems we don't have test for fts.c, do we? > > Not that I know of. > For effective testing of this you'd have to use something like cmocka, > or more generically something like CharybdeFS
For rm(1), we could add a gdb-based or LD_PRELOAD-based test. Current rm(1) will fail to remove a recursive directory (because some files beneath the directory hierarchy didn't get deleted), while the fixed one will return with an FTS error message like "readdir() failed". Obviously, many other packages usig FTS like find(1) are also affected. Have a nice day, Berny
