On 31/12/14 07:44, Paul Eggert wrote: > Pádraig Brady wrote: >> +2014-12-30 Pádraig Brady<p...@draigbrady.com> >> + >> + xstrtol: ensure errno is reset >> + Since commit 3bf75404, on 26-09-1998, errno may not have been reset. >> + Noticed with a spurious coreutils test failure on Darwin 14.0.0. > > Sorry, can you explain more? First, why does xstrtol's caller care about > errno > -- isn't that a bug?
Well strtol is documented to return ERANGE in certain cases, and the coreutils xdectoint wrapper uses and sets errno to give more accurate diagnostics. > Second, can't isspace set errno and won't this cause problems? That would be surprising. At least we have a test in place for that now. thanks, Pádraig.
