Hi/2. Daiki Ueno wrote: > Hello, > > The change should work, but I have a feeling that something is wrong: > >> +# if defined OS2 >> + /* To avoid the troubles of installing a separate file in the same >> + directory as the DLL and of retrieving the DLL's directory at >> + runtime, simply inline the aliases here. */ >> + >> + cp = "bg_BG" "\0" "CP1251" "\0" > > You are adding locale-to-charset mappings here, while all other mappings > defined are charset-to-charset. Perhaps such a mappings could be > resolved in intl/localealias.c through the locale.alias file instead? > > Your change might be necessary for other consumers than gettext. If so, > could you explain the actual use-case in the ChangeLog and/or the above > comment? >
I'm using this in libiconv. On OS/2, a charset is not specified generally. Just only a locale is specified. And all LC_xxx are not specified. Just only LANG is specified. For examples, set LANG=ko_KR for Korean. And the case that charset aliases are used is that '.' to specify a charset is not found or a buffer is overflowed, which is impossible if a charset is correct. So charset-to-charset mapping is not useful on OS/2. > Also if it changes anything in the OS/2 port of gettext, consider > updating this file: > http://git.savannah.gnu.org/cgit/gettext.git/tree/os2/README.OS2 > Ok. If I work on gettext later, I'll consider. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr
