umerqayam <umeqa...@linux.vnet.ibm.com> writes:
> Description:
> Testcase libunistring is failing in its subtest ( libunistring-0.9.3/tests/
> unicase/test-locale-language.sh ) test-locale-language.sh, the reason was all
> its code was using UTF8 encoding format some how in the beginning some section
> was not implemented to use UTF8 Encoding format, hence the failure.
>
> Solution:
> UTF8 encoding format has been appended to the code where it was missing
> earlier.
Thanks for the detailed report and the patch.
> -: ${LOCALE_FR=fr_FR}
> +: ${LOCALE_FR_UTF8=fr_FR.UTF-8}
> if test $LOCALE_FR_UTF8 != none; then
> LC_ALL=$LOCALE_FR_UTF8 ./test-locale-language${EXEEXT} fr || exit 1
There is already a test for fr_FR.UTF-8 below the line, and repeating
the test makes little sense. I'm thinking of the attached patch.
Regards,
--
Daiki Ueno
>From 255abc0e9f6b044a9aacaaa8ed200dd9a3362899 Mon Sep 17 00:00:00 2001
From: Daiki Ueno <u...@gnu.org>
Date: Fri, 12 Dec 2014 09:20:59 +0900
Subject: [PATCH] unicase/locale-language-tests: fix LOCALE_FR test
* tests/unicase/test-locale-language.sh: Really use $LOCALE_FR for
a French locale with traditional encoding.
Reported by umerqayam in:
http://lists.gnu.org/archive/html/bug-libunistring/2014-12/msg00000.html
---
ChangeLog | 8 ++++++++
tests/unicase/test-locale-language.sh | 4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 5fac19d..b4a0534 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2014-12-12 Daiki Ueno <u...@gnu.org>
+
+ unicase/locale-language-tests: fix LOCALE_FR test
+ * tests/unicase/test-locale-language.sh: Really use $LOCALE_FR for
+ a French locale with traditional encoding.
+ Reported by umerqayam in:
+ http://lists.gnu.org/archive/html/bug-libunistring/2014-12/msg00000.html
+
2014-12-09 Paul Eggert <egg...@cs.ucla.edu>
posixtm: avoid compiler warning in a better way
diff --git a/tests/unicase/test-locale-language.sh b/tests/unicase/test-locale-language.sh
index 0a04a0d..2aa3460 100755
--- a/tests/unicase/test-locale-language.sh
+++ b/tests/unicase/test-locale-language.sh
@@ -3,8 +3,8 @@
LC_ALL=C ./test-locale-language${EXEEXT} '' || exit 1
: ${LOCALE_FR=fr_FR}
-if test $LOCALE_FR_UTF8 != none; then
- LC_ALL=$LOCALE_FR_UTF8 ./test-locale-language${EXEEXT} fr || exit 1
+if test $LOCALE_FR != none; then
+ LC_ALL=$LOCALE_FR ./test-locale-language${EXEEXT} fr || exit 1
fi
: ${LOCALE_FR_UTF8=fr_FR.UTF-8}
--
2.1.3
