On 10/23/2014 04:43 AM, Pádraig Brady wrote:
Except for the assert() nit, I can't find any issues.
My only nit was adding the "#if 0"; might as well just delete the code instead. I only read the code; I didn't test it.
- [PATCH v2 04/10] uniwbrk: Ignore Extended/Format at the beg... Daiki Ueno
- [PATCH v2 09/10] Update to Unicode 6.3.0 Daiki Ueno
- [PATCH v2 06/10] uniname: Make codepoint transformation mor... Daiki Ueno
- [PATCH v2 05/10] uniwbrk/u32-wordbreaks-tests: Test using W... Daiki Ueno
- [PATCH v2 08/10] Update to Unicode 6.2.0 Daiki Ueno
- [PATCH v2 07/10] Update to Unicode 6.1.0 Daiki Ueno
- [PATCH v2 03/10] unictype/joininggroup-of: Switch to 3-leve... Daiki Ueno
- [PATCH v2 02/10] gen-uni-tables: Check out-of-range values ... Daiki Ueno
- Re: [PATCH v2 00/10] Update libunistring-related modules to... Pádraig Brady
- Re: [PATCH v2 00/10] Update libunistring-related modul... Paul Eggert
