Hello, After adding a couple gnulib modules to coreutils I get several warnings. As a result, make fails since -Werror is enabled by default. If I configure with --disable-gcc-warnings then the warnings go away. The culprit seems to be avltree-list:
diff --git bootstrap.conf bootstrap.conf index c0b5f02..a362376 100644 --- bootstrap.conf +++ bootstrap.conf @@ -34,6 +34,7 @@ gnulib_modules=" argv-iter assert autobuild + avltree-list backupfile base64 buffer-lcm @@ -268,6 +269,7 @@ gnulib_modules=" xgetcwd xgetgroups xgethostname + xlist xmemcoll xnanosleep xprintf lib/gl_avltree_list.c:63:1: error: no previous declaration for 'gl_avltree_list_check_invariants' [-Werror=missing-declarations] gl_avltree_list_check_invariants (gl_list_t list) ^ In file included from lib/gl_avltree_list.c:37:0: lib/gl_avltree_list.c: In function 'gl_tree_next_node' lib/gl_anytree_list2.h:104:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_tree_next_node (gl_list_t list, gl_list_node_t node) ^ lib/gl_avltree_list.c: In function 'gl_tree_previous_node' lib/gl_anytree_list2.h:122:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_tree_previous_node (gl_list_t list, gl_list_node_t node) ^ lib/gl_avltree_list.c: In function 'node_at' lib/gl_anytree_list2.h:141:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] node_at (gl_list_node_t root, size_t position) ^ lib/gl_avltree_list.c: In function 'check_invariants' lib/gl_avltree_list.c:41:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] check_invariants (gl_list_node_t node, gl_list_node_t parent) ^ In file included from lib/gl_avltree_list.c:37:0: lib/gl_avltree_list.c: In function 'gl_tree_get_at' lib/gl_anytree_list2.h:166:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_tree_get_at (gl_list_t list, size_t position) ^ lib/gl_avltree_list.c: In function 'gl_avltree_list_check_invariants' lib/gl_avltree_list.c:63:1: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=suggest-attribute=pure] gl_avltree_list_check_invariants (gl_list_t list) ^ Let me know if you need any further information. Thanks, Dylan
