Hello there,

the module parse-datetime suffers from an annoying warning,
due to a comparison of a pointer difference to an unsigned
integer. Please mend this.

Best regards,
  Mats Erik Andersson, on behalf of GNU Shishi
>From c01f49c76af992fc84357e8e346c3494f90258ce Mon Sep 17 00:00:00 2001
From: Mats Erik Andersson <g...@gisladisker.se>
Date: Sat, 30 Aug 2014 10:31:35 +0200
Subject: [PATCH] parse-datetime: Avoid pointer difference.

* lib/parse-datetime.y (yylex): Compare pointer to end of buffer,
instead of calculating difference of pointers.  This removes an
annoying warning, devoid of any use.
---
 ChangeLog            | 7 +++++++
 lib/parse-datetime.y | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index a1f9602..c48ca83 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2013-08-30  Mats Erik Andersson  <g...@gisladisker.se>  (tiny change)
+
+	parse-datetime: Avoid pointer difference.
+	* lib/parse-datetime.y (yylex): Compare pointer to end of buffer,
+	instead of calculating difference of pointers.  This removes an
+	annoying warning, devoid of any use.
+
 2014-08-29  Paul Eggert  <egg...@cs.ucla.edu>
 
 	qsort_r: new module, for GNU-style qsort_r
diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y
index 0ba0a52..52e6a0c 100644
--- a/lib/parse-datetime.y
+++ b/lib/parse-datetime.y
@@ -1161,7 +1161,7 @@ yylex (YYSTYPE *lvalp, parser_control *pc)
 
           do
             {
-              if (p - buff < sizeof buff - 1)
+              if (p < buff + sizeof buff - 1)
                 *p++ = c;
               c = *++pc->input;
             }
-- 
2.1.0.rc1

Reply via email to