On 02/20/2014 07:00 AM, Eric Blake wrote: > Roman Bogorodskiy reported that attempts to use 'make syntax-check' > for libvirt on a BSD host was failing, due to libvirt's use of > GNU sed constructs in cfg.mk. While libvirt could be patched to > use only portable sed constructs, it is also worth making sed > replaceable so that any maintainer can use a consistent sed program > rather than being hardcoded to the first 'sed' on $PATH. > > * modules/maintainer-makefile (configure.ac): Check for sane sed. > * top/maint.mk: Change sed to $(SED). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > ChangeLog | 6 ++++++ > modules/maintainer-makefile | 1 + > top/maint.mk | 35 ++++++++++++++++++----------------- > 3 files changed, 25 insertions(+), 17 deletions(-)
Pavel Hrdina reported that I'll need to do a followup for RHEL 5 which still uses autoconf 2.59: AC_PROG_SED was introduced in autoconf 2.60, so gnulib now needs to provide a backup definition. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
