On 01/23/2014 02:44 AM, Pádraig Brady wrote: > On 01/23/2014 05:38 AM, Eric Blake wrote: >
>> + [[#include <pthread.h> >> + #ifdef strtok_r >> + #error >> + break me >> + #endif >> + ]])], >> + [gl_cv_header_pthread_h_pollution=no], >> + [gl_cv_header_pthread_h_pollution=yes])]) > > Would it be worth defining MINGW_PTHREAD_H_POLLUTION here > for use as a guard for the undefs in pthread.in.h > in case those were valid defines on some platform? > I'm not suggesting just curious. I don't see a reason for it at the present - unlike most replacement headers that we build unconditionally, pthread.h is still one where the replacement is only conditional. We can revisit it if someone reports a problem. > > Anyway the fix makes sense and looks good. Thanks; I'll push it shortly. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
