On 01/04/13 15:27, Bruce Korb wrote:
> This fixes it:
>
> 261 memcpy (ctx->buffer, buffer, 64);
> 262 md5_process_block (ctx->buffer, 64, ctx);
>
> There's no particular reason for having a nested call there anyway.
>
>From 200eb0ed19376b71f4ca8706c1db83be21a59372 Mon Sep 17 00:00:00 2001
From: Bruce Korb <bk...@gnu.org>
Date: Fri, 4 Jan 2013 15:37:17 -0800
Subject: [PATCH] md5: avoid erroneous construct
* lib/md5.c (md5_process_bytes): un-nest a function call to avoid
a ``invalid use of void expression'' error.
---
ChangeLog | 5 +++++
lib/md5.c | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index f036ac1..9144aac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-01-04 Bruce Korb <bk...@gnu.org>
+
+ * lib/md5.c (md5_process_bytes): un-nest a function call to avoid
+ a ``invalid use of void expression'' error.
+
2013-01-04 Paul Eggert <egg...@cs.ucla.edu>
fprintftime: bring back and reword fwrite comment
diff --git a/lib/md5.c b/lib/md5.c
index c41538c..d90783b 100644
--- a/lib/md5.c
+++ b/lib/md5.c
@@ -258,7 +258,8 @@ md5_process_bytes (const void *buffer, size_t len, struct md5_ctx *ctx)
if (UNALIGNED_P (buffer))
while (len > 64)
{
- md5_process_block (memcpy (ctx->buffer, buffer, 64), 64, ctx);
+ memcpy (ctx->buffer, buffer, 64);
+ md5_process_block (ctx->buffer, 64, ctx);
buffer = (const char *) buffer + 64;
len -= 64;
}
--
1.7.10.4
