On 06/21/12 12:41, Bruno Haible wrote:
Your commit came without a ChangeLog entry. I added one for you:
Woops. Thanks you so much!
On 06/21/12 12:41, Bruno Haible wrote:
Or, even better in my opinion: All the trouble has been caused my the
desire to keep a shell script and a data table in the same file. Separate
them. Move the test data into a file of its own, say
tests/test-parse-duration-data.txt. Then you don't need a temporary dir,
you don't need a 'trap' command, just a
while read line< ${srcdir}/test-parse-duration-data.txt
Except for the file being re-opened on each iteration,
that is a good idea. In general, though, when I use a here doc,
I use the strip-the-tabs form because it looks _much_ cleaner.
In this case, this:
while read line ; do
...
done < ${srcdir}/test-parse-duration-data.txt
combined with the trap handling removal is a lot better.
