FYI, I've pushed the change below. Can anyone think of a common way to use "all these" that is not in error? So far, all of the uses I've seen are wrong, and instead should be written "all of these".
See below for a list of the violations in gnulib: I won't go changing FDL text (obviously), but propose to fix all of the others. Any objection? >From 70a9bd65b77ec4e516f500e7348bc1c332d91ea5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[email protected]> Date: Sun, 10 Jun 2012 21:49:59 +0200 Subject: [PATCH] maint.mk: prohibit common grammar error: "all these" * top/maint.mk (prohibit_undesirable_word_seq_RE_): Add "all these" to the list of prohibited word sequences. It should be "all of these". * lib/tempname.c (__gen_tempname): Fix one of them. --- ChangeLog | 7 +++++++ lib/tempname.c | 2 +- top/maint.mk | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 55a459b..7f27d17 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2012-06-10 Jim Meyering <[email protected]> + + maint.mk: prohibit common grammar error: "all these" + * top/maint.mk (prohibit_undesirable_word_seq_RE_): Add "all these" to + the list of prohibited word sequences. It should be "all of these". + * lib/tempname.c (__gen_tempname): Fix one of them. + 2012-06-07 Akim Demaille <[email protected]> do-release-commit-and-tag: support VPATH builds diff --git a/lib/tempname.c b/lib/tempname.c index de0474d..26a38ce 100644 --- a/lib/tempname.c +++ b/lib/tempname.c @@ -207,7 +207,7 @@ __gen_tempname (char *tmpl, int suffixlen, int flags, int kind) /* A lower bound on the number of temporary files to attempt to generate. The maximum total number of temporary file names that can exist for a given template is 62**6. It should never be - necessary to try all these combinations. Instead if a reasonable + necessary to try all of these combinations. Instead if a reasonable number of names is tried (we define reasonable as 62**3) fail to give the system administrator the chance to remove the problems. */ #define ATTEMPTS_MIN (62 * 62 * 62) diff --git a/top/maint.mk b/top/maint.mk index f0b889b..bcdbe01 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -948,7 +948,7 @@ sc_prohibit_doubled_word: bad_xref_re_ ?= (?:[\w,:;] +|(?:see|also)\s+)\@xref\{ bad_pxref_re_ ?= (?:[.!?]|(?:see|also))\s+\@pxref\{ prohibit_undesirable_word_seq_RE_ ?= \ - /(?:\bcan\s+not\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims + /(?:\bcan\s+not\b|\ball these\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims prohibit_undesirable_word_seq_ = \ -e 'while ($(prohibit_undesirable_word_seq_RE_))' \ $(perl_filename_lineno_text_) -- 1.7.11.rc2 $ git grep -i '\<all.these\>' ChangeLog: maint.mk: prohibit common grammar error: "all these" ChangeLog: * top/maint.mk (prohibit_undesirable_word_seq_RE_): Add "all these" to ChangeLog: all these functions' values are checked (so that ferror need not build-aux/texinfo.tex:% Now for the actual typesetting. In all these, #1 is the text and #2 is the doc/fdl-1.2.texi:copies in covers that carry, clearly and legibly, all these Cover doc/fdl-1.3.texi:copies in covers that carry, clearly and legibly, all these Cover doc/fdl.texi:copies in covers that carry, clearly and legibly, all these Cover doc/maintain.texi:creating all these different formats and index pages easier. doc/maintain.texi:self-defeating to try to find and avoid all these patents. But there doc/parse-datetime.texi:numerically or literally. All these strings specify the same calendar date: doc/relocatable.texi:Here's a sample installation run that takes into account all these doc/standards.texi:all these kinds of files. lib/memchr.c: /* All these elucidatory comments refer to 4-byte longwords, lib/memchr2.c: /* All these elucidatory comments refer to 4-byte longwords, lib/memrchr.c: /* All these elucidatory comments refer to 4-byte longwords, lib/rawmemchr.c: /* All these elucidatory comments refer to 4-byte longwords, lib/spawn-pipe.h:/* All these functions create a subprocess and don't wait for its termination. lib/strchrnul.c: /* All these elucidatory comments refer to 4-byte longwords, lib/timespec.h: In all these cases, it is safe to subtract two tv_nsec values and m4/wctype_h.m4: dnl HP-UX 11.00 declares all these in <wchar.h> and lacks <wctype.h>.
