Michael Goffioul wrote: > On Thu, May 31, 2012 at 8:08 PM, Jim Meyering <j...@meyering.net> wrote: > > Michael Goffioul wrote: > > While trying to compile current octave source with MSVC, I got an error > at > the > > compilation of savewd.c, because of missing sys/wait.h header. Indeed > that > > header is included directly by savewd.c, but the savewd module does not > depend > > on sys_wait. So the gnulib replacement for sys/wait.h is not pulled in > (and > > MSVC9 does not provide that header). > > > > Should savewd module depend on sys_wait one? > > Hi Michael, > > Thanks for the report. > The lib/savewd.c I see does not directly include sys/wait.h. > > Yes it does [1], line 31. > > Michael. > > [1] http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/savewd.c;h= > c5aec365ec40fd3b54e537d0ed2f6cce3d874e74;hb=HEAD
Of course it does, when I read that as savewd.c, not save-cwd.c. The "-c" makes a difference. http://git.sv.gnu.org/cgit/gnulib.git/tree/lib/savewd.c http://git.sv.gnu.org/cgit/gnulib.git/tree/lib/save-cwd.c Yes, that looks like an oversight. Thanks again. I'll push this fix shortly: >From 587ed1ef4a439415c5565f73ecb9c017161c9572 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Thu, 31 May 2012 21:30:10 +0200 Subject: [PATCH] savewd: add missing dependency on sys_wait module * modules/savewd (Depends-on): Add sys_wait, needed at least for MSVC. Report and suggested change by Michael Goffioul. --- ChangeLog | 6 ++++++ modules/savewd | 1 + 2 files changed, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index 4dc5c1e..fa51591 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2012-05-31 Jim Meyering <meyer...@redhat.com> + + savewd: add missing dependency on sys_wait module + * modules/savewd (Depends-on): Add sys_wait, needed at least + for MSVC. Report and suggested change by Michael Goffioul. + 2012-05-29 Paul Eggert <egg...@cs.ucla.edu> system-quote-tests: port to CentOS 5 diff --git a/modules/savewd b/modules/savewd index 9a7b8c7..bb48c06 100644 --- a/modules/savewd +++ b/modules/savewd @@ -16,6 +16,7 @@ fcntl-h raise stdbool stdlib +sys_wait xalloc configure.ac: -- 1.7.10.2.605.gbefc5ed
