Bruno Haible <br...@clisp.org> writes: > Hi Simon, > >> I have reverted the strdup and select patch, and I'll treat >> this as a user error. > > It was a user error. But the select.c patch was good: it fixed an > earlier-undetected mistake (that would have likely been a compilation > error on Interix).
However Interix probably made NULL available through the sys/select.h header so it worked, assuming someone tested the Interix code. I usually prefer to patch based on actual bug reports rather than guessing. I wouldn't be opposed to re-adding that part though. /Simon