Gijs van Tulder <gvtul...@gmail.com> writes: > Simon Josefsson wrote: >> Once the copyright papers are resolved, I can commit it >> unless someone else beats me to it. > > Hi. The copyright should be solved now. I've attached the patch for > the base32 module again. (I've changed the RFC reference to point to > the newest version.)
Thank you for updated patch and your patience with the assignment process. I have pushed your patch. There seems to be some memory leaks in the self-tests, although maybe they are inherited from the base64 self-test? Getting rid of memory leaks in self-tests can be useful to make sure that none of them really are memory leaks in the real code. /Simon ==14606== HEAP SUMMARY: ==14606== in use at exit: 95 bytes in 8 blocks ==14606== total heap usage: 17 allocs, 9 frees, 188 bytes allocated ==14606== ==14606== 5 bytes in 1 blocks are definitely lost in loss record 1 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x400F85: main (test-base32.c:199) ==14606== ==14606== 5 bytes in 1 blocks are definitely lost in loss record 2 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x400FFD: main (test-base32.c:208) ==14606== ==14606== 5 bytes in 1 blocks are definitely lost in loss record 3 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x401043: main (test-base32.c:212) ==14606== ==14606== 5 bytes in 1 blocks are definitely lost in loss record 4 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x40106B: main (test-base32.c:222) ==14606== ==14606== 10 bytes in 1 blocks are definitely lost in loss record 5 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x400FB4: main (test-base32.c:203) ==14606== ==14606== 15 bytes in 1 blocks are definitely lost in loss record 6 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x400F34: main (test-base32.c:192) ==14606== ==14606== 25 bytes in 1 blocks are definitely lost in loss record 7 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x400E9B: main (test-base32.c:171) ==14606== ==14606== 25 bytes in 1 blocks are definitely lost in loss record 8 of 8 ==14606== at 0x4C244E8: malloc (vg_replace_malloc.c:236) ==14606== by 0x401DC1: base32_decode_alloc_ctx (base32.c:573) ==14606== by 0x400EE5: main (test-base32.c:182)
