On 09/07/11 02:49, Bruno Haible wrote: > -#include <fcntl.h> > +/* Write "fcntl.h" here, not <fcntl.h>, otherwise OSF/1 5.1 DTK cc > miscompiles > + openat.c because that file has a preliminary #include <fcntl.h>. */ > +#include "fcntl.h"
Thanks. Is a similar change needed to lib/open.c, which plays the same trick with fcntl.h? Also, to lib/fstatat.c, lib/lstat.c, lib/stat.c, which play a similar trick with <sys/stat.h>? And if so, why didn't these other examples turn up in testing? And if not, it might not hurt to add a comment to openat.h explaining that the bug affects only indirect includes, or whatever the difference is.
