> > The assumption was that the vast majority of programs use stdio and > > fclose(). > > But I agree with you, it would be more in line with the gnulib principles > > to let the programmer who needs specific features from fclose() to > > explicitly > > request the 'fclose' module. > > > > Any objections to removing this dependency? > > None by me, as long as the fdopen/fclose pair still works on mingw sockets.
OK, I've applied the change: 2011-07-24 Bruno Haible <br...@clisp.org> close: No longer depend on module 'fclose'. * modules/close (Depends-on): Remove fclose. * NEWS: Mention the change. Suggested by Sam Steingold <s...@gnu.org>. --- NEWS.orig Sun Jul 24 12:37:10 2011 +++ NEWS Sun Jul 24 12:35:21 2011 @@ -12,6 +12,12 @@ Date Modules Changes +2011-07-24 close This module no longer pulls in the 'fclose' module. + If your code creates a socket descriptor using + socket() or accept(), then a FILE stream referring + to it using fdopen(), then in order to close this + stream, you need the 'fclose' module. + 2011-07-12 arg-nonnull Renamed to snippet/arg-nonnull. c++defs Renamed to snippet/c++defs. link-warning Renamed to snippet/link-warning. --- modules/close.orig Sun Jul 24 12:37:10 2011 +++ modules/close Sun Jul 24 12:29:07 2011 @@ -8,7 +8,6 @@ Depends-on: unistd fd-hook [test $REPLACE_CLOSE = 1] -fclose configure.ac: gl_FUNC_CLOSE -- In memoriam Ezechiele Ramin <http://en.wikipedia.org/wiki/Ezechiele_Ramin>