> 2 x FAIL: test-roundf-ieee
I'm seeing these failures:
AIX 7.1
test-roundf-ieee.c:40: assertion failed
/bin/sh: 11206706 IOT/Abort trap(coredump)
FAIL: test-roundf-ieee
OSF/1 5.1
test-roundf-ieee.c:35: assertion failed
sh: 114831 Abort - core dumped
FAIL: test-roundf-ieee
Adding floorf-ieee as dependency fixes the first failure on OSF/1:
AIX 7.1
test-roundf-ieee.c:40: assertion failed
/bin/sh: 16318542 IOT/Abort trap(coredump)
FAIL: test-roundf-ieee
OSF/1 5.1
test-roundf-ieee.c:40: assertion failed
sh: 139478 Abort - core dumped
FAIL: test-roundf-ieee
Adding ceilf-ieee as dependency fixes also the second failure on OSF/1:
AIX 7.1
test-roundf-ieee.c:40: assertion failed
/bin/sh: 16318542 IOT/Abort trap(coredump)
FAIL: test-roundf-ieee
OSF/1 5.1
PASS: test-ceilf-ieee
Enforcing the replacement fixes also the failure on AIX. I'm committing the
complete fix:
2011-06-19 Bruno Haible <br...@clisp.org>
roundf-ieee: Fix test failures on AIX 7.1 and OSF/1 5.1.
* m4/roundf.m4 (gl_FUNC_ROUNDF): Test also the sign of roundf (-0.3f).
* modules/roundf-ieee (Depends-on): Add floorf-ieee, ceilf-ieee.
* doc/posix-functions/roundf.texi: Mention problem with negative
arguments.
* doc/posix-functions/ceilf.texi: Mention problem on OSF/1 5.1.
--- doc/posix-functions/ceilf.texi.orig Sun Jun 19 14:01:24 2011
+++ doc/posix-functions/ceilf.texi Sun Jun 19 13:51:32 2011
@@ -18,7 +18,7 @@
@item
This function returns a positive zero for an argument between -1 and 0
on some platforms:
-MacOS X 10.5, AIX 7.1.
+MacOS X 10.5, AIX 7.1, OSF/1 5.1.
@item
This function returns a positive zero for a minus zero argument
on some platforms:
--- doc/posix-functions/roundf.texi.orig Sun Jun 19 14:01:24 2011
+++ doc/posix-functions/roundf.texi Sun Jun 19 13:54:39 2011
@@ -22,6 +22,10 @@
Portability problems fixed by Gnulib module @code{roundf-ieee}:
@itemize
@item
+This function returns a positive zero for an argument between -0.5 and 0
+on some platforms:
+AIX 7.1, OSF/1 5.1.
+@item
This function returns a positive zero for a minus zero argument
on some platforms:
OSF/1 5.1.
--- m4/roundf.m4.orig Sun Jun 19 14:01:24 2011
+++ m4/roundf.m4 Sun Jun 19 13:54:01 2011
@@ -1,4 +1,4 @@
-# roundf.m4 serial 12
+# roundf.m4 serial 13
dnl Copyright (C) 2007-2011 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -70,10 +70,14 @@
int main (int argc, char *argv[])
{
float (*my_roundf) (float) = argc ? roundf : dummy;
+ int result = 0;
/* Test whether roundf (-0.0f) is -0.0f. */
if (signbitf (minus_zerof) && !signbitf (my_roundf (minus_zerof)))
- return 1;
- return 0;
+ result |= 1;
+ /* Test whether roundf (-0.3f) is -0.0f. */
+ if (signbitf (-0.3f) && !signbitf (my_roundf (-0.3f)))
+ result |= 2;
+ return result;
}
]])],
[gl_cv_func_roundf_ieee=yes],
--- modules/roundf-ieee.orig Sun Jun 19 14:01:24 2011
+++ modules/roundf-ieee Sun Jun 19 13:33:30 2011
@@ -8,6 +8,8 @@
Depends-on:
roundf
+floorf-ieee [test $HAVE_DECL_ROUNDF = 0 || test $REPLACE_ROUNDF = 1]
+ceilf-ieee [test $HAVE_DECL_ROUNDF = 0 || test $REPLACE_ROUNDF = 1]
configure.ac:
gl_FUNC_ROUNDF_IEEE
--
In memoriam Alois Eliáš <http://en.wikipedia.org/wiki/Alois_Eliáš>
