Stefano Lattarini wrote: > On Tuesday 07 June 2011, Jim Meyering wrote: >> Hi Stefano, >> > Hello Jim, thanks for the quick review. > >> Thanks for the patch. This looks fine, though you might want >> to adjust the commit log and ChangeLog nits: >> >> Stefano Lattarini wrote: >> > Before this patch, the only way offered by tests/init.sh to >> > properly signal an hard error was the `framework_failure_' >> >> s/an hard/a hard/ >> >> > subroutine. But the error message issued by that subroutine, >> >> "function" sounds a little better ;-) >> s/subroutine/function/ >> (multiple times) >> > Done in the attached patch. If this amended patch is OK, please > go ahead and apply it, because I don't have pushing right for > gnulib. ... > Subject: [PATCH] tests init: new function 'fatal_', for hard errors > > Before this patch, the only way offered by tests/init.sh to > properly signal a hard error was the `framework_failure_' > function. But the error message issued by that function, > as its name would suggest, refers to a set-up failure in the > testsuite, while hard errors can obviously also be due to > other reasons. The best way to fix this inconsistency is to > introduce a new function with a more general error message.
Thanks. You're welcome to push that.
