On 06/07/2011 05:57 AM, Stefano Lattarini wrote:
> * tests/init.sh (mktempd_): In the usage message, use literal
> 'mktempd_', not '$ME' (which is even undefined), as the name of
> the subroutine.
> ---
>  ChangeLog     |    7 +++++++
>  tests/init.sh |    2 +-
>  2 files changed, 8 insertions(+), 1 deletions(-)

$ME is undefined, but $ME_ is defined earlier to init.sh; I think the
original bug was a missing trailing underscore.

However, within the function mktempd_, it seems like it is better to use
the function name than the overall dot-file name in the usage message
for that function.

So I like this patch as-is.

-- 
Eric Blake   ebl...@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to