On 05/20/2011 12:42 PM, Bruno Haible wrote: > Hi Eric, > >> This change means that now strerror depends on strerror_r-posix, and >> strerror_r-posix depends on strerror. Is that circular dependency okay >> for gnulib-tool? > > Yes, gnulib-tool supports circular dependencies, even with > --conditional-dependencies. > > But the circular dependency was not intended. Fixing it:
Oh my. This makes my recent test-perror2 fail on FreeBSD, because it tests that perror and strerror match (as per POSIX), rather than strerror_r, but our perror replacement kicks in even when the strerror replacement does not. I'm debating if there is a better way to fix this, but am pushing this as the minimal fix for now: diff --git i/modules/perror-tests w/modules/perror-tests index 9a6ba47..3770d77 100644 --- i/modules/perror-tests +++ w/modules/perror-tests @@ -7,6 +7,7 @@ tests/test-perror2.c tests/test-perror.sh Depends-on: +strerror configure.ac: -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
