On 04/29/2011 01:51 PM, Reuben Thomas wrote: > I'm trying to prepare a small cosmetic patch to fix up a couple of > things I find myself manually fixing up: > > 1. "./NEWS". I considered replacing this with the basename of the NEWS > file, but in fact it seems to me it's better to use the literal "NEWS" > since that makes more sense in the email. What do you think? > > 2. In the email subject, better use $package_name $curr_version than > $my_distdir. > > I would already have sent this patch, but there's another problem: I > use whitespace-mode, and it stumbles because, although I've now set > indent-tabs-mode to t in the file announce-gen (this will be part of > my patch), it turns out that the file is neither one thing nor the > other, since although it mostly uses tabs, it doesn't use tabs in the > usage message, but spaces. Is there some even-more-magic setting I can > use which will make whitespace-mode happy to replace spaces with tabs > in parts of the file but not in other parts, or should I add another > file-local setting to turn it off?
Or better yet, change indent-tabs-mode to nil, convert the file to all spaces (no indentation for tabs) as a separate prereq commit to your actual changes, thereby making that file match the style of the rest of gnulib (tabs as indentation only for Makefile snippets and such). -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
