On 04/26/2011 05:35 PM, Eric Blake wrote: > Ever since commit 2392b18099, fdopendir no longer drags in xalloc-die > through indirect dependencies, so this test no longer needs $(LIBINTL). > > * modules/dirent-safer-tests (Makefile.am): Drop stale LDADD.
NAK to this patch (but that doesn't affect the other 8 in the series). In isolation, test-dirent-safer doesn't use fdopendir; but with dirent-safer and fdopendir used at the same time, then xalloc is still being pulled in. That is, commit 2392b18 dropped xalloc-die for openat, but fdopendir is using more than openat and still dragging in xalloc through some other path. [Hmm, './gnulib-tool --test openat' excludes xalloc-die, but './gnulib-tool --test --with-tests openat' pulls it in - I'm still investigating...] > +++ b/modules/dirent-safer-tests > @@ -10,6 +10,3 @@ configure.ac: > Makefile.am: > TESTS += test-dirent-safer > check_PROGRAMS += test-dirent-safer > -# Link with libintl when needed. dirent-safer uses fdopendir if it is > present, > -# and fdopendir indirectly depends on xgetcwd -> xalloc-die -> gettext-h. > -test_dirent_safer_LDADD = $(LDADD) $(LIBINTL) -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
