On 21/01/11 12:41, Bruno Haible wrote:
> Hi Pádraig,
> 5) The unit test tests/unistr/test-u-strstr.h: It is good to share code among
> tests.
> rather than write down the same code 3 times. But please follow GNU coding
> style:
> indentation by 2 spaces, not 4, and put spaces around arithmetic operators.
> More importantly, though, the test code that you put there is part of
> tests/test-strstr.c and tests/test-mbsstr1.c. Why only a part? u16_strstr and
> u32_strstr should have all the properties that strstr and mbsstr have. So the
> right thing to do is to adapt all of tests/test-strstr.c into
> tests/unistr/test-u-strstr.h. I've done this, and now I get test failures:
>
> /bin/sh: line 5: 24308 Alarm clock EXEEXT='' srcdir='.'
> MAKE='make' ${dir}$tst
> FAIL: test-u16-strstr
> /bin/sh: line 5: 24325 Alarm clock EXEEXT='' srcdir='.'
> MAKE='make' ${dir}$tst
> FAIL: test-u32-strstr
Yes I was being a bit lazy here.
Eek, can you attached your updated test-u-strstr.h
> So, the first part that can go in is this:
>
>
> 2011-01-21 Pádraig Brady <[email protected]>
> Bruno Haible <[email protected]>
>
> Prepare for faster uN_strstr functions.
OK, I'll adjust on top of that.
Thanks for the review!
Pádraig.
