On 01/06/2011 08:03 AM, Jim Meyering wrote:
>>> +submodule-checks = no-submodule-changes public-submodule-commit
>>
>> If someone complains about these two tests being git-centric, a solution
>> for a project using maint.mk with a different VCS would be to make
>> submodule-checks defined via ?=, so that it can be overridden in cfg.mk
>> to an empty macro to skip git submodule consistency checks.  But I'm
>> okay using = instead of ?= and waiting until someone requests that extra
>> flexibility, if you don't want to change it now.
> 
> Good idea.
> I've also made the test silently skip when there is no .git/ directory,
> just like no-submodule-changes rule does.
> 
> One more iteration:

ACK.

-- 
Eric Blake   [email protected]    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to