On 12/25/2010 01:49 AM, Bruno Haible wrote:
1) The code for pipe() on Win32 is now in module 'pipe-posix'. And 'pipe-posix' depends on 'unistd'.
Ok.
2) The arguments passed to function connect_to_socket() are true and false. So it's actually a 'bool' argument.
Ok.
3) Because at least some Linux versions return in the timeout parameter the unslept time (see<http://linux.die.net/man/2/select>), it is good practice to not reuse a 'struct timeval' from a previous select() call for the next select() call. Even though in this case the unslept time is probably always zero, better use the safe way of coding.
Not really sure it's worth changing (the unslept time cannot be anything but zero---it would be a bug if otherwise!)... but since the patch is done, fine.
4) A couple of comments for do_select(), since this function is used in all the tests. (The reader may not be familiar with poll().)
Ok.
