On 12/10/2010 08:04 PM, Bruno Haible wrote: > Hi Eric, > >> cloexec (currently LGPLv3+), fcntl (currently LGPLv3+). >> Are there any objections to relaxing the license? > > Fine with me. lib/fcntl.c contains some originally GPLed code from me > (the DuplicateHandle stuff: originally in lib/w32spawn.h under GPL, > moved to lib/cloexec.c on 2009-12-05, became LGPLv3+ on 2009-12-10, > moved to lib/fcntl.c on 2009-12-16), but that is not worth considering > as very valuable. > > Eric Blake wrote: >> I will want to make open (LGPLv2+) depend on cloexec > > We carefully avoided to have such a dependency. I guess that at least > some people would consider it "creepy dependencies": The 'open' module fixes > a number of problems that people usually want to avoid. But 'cloexec' > is useful only in programs that spawn subprocesses. Programs that simply > manipulate files without having subprocesses will not need this. How > about having two modules 'open' and 'open-cloexec' (or maybe 'open-posix')?
Yes, this point has been raised in the past. I certainly agree that a
process with no children doesn't need the overhead of guaranteeing an
open() wrapper that supports O_CLOEXEC, so definitely splitting things
into two modules is worthwhile. In fact, I'm wondring if the best
approach might even be to just have the existing cloexec module be the
key for whether O_CLOEXEC is guaranteed to be supported in open.
At any rate, all contributors have replied, so I'm pushing this:
diff --git i/ChangeLog w/ChangeLog
index 261ea39..62b9dca 100644
--- i/ChangeLog
+++ w/ChangeLog
@@ -1,3 +1,10 @@
+2010-12-13 Eric Blake <ebl...@redhat.com>
+
+ cloexec, fcntl: relax license
+ * modules/cloexec (License): Change from LGPLv3+ to LGPLv2+, with
+ consent from all contributors.
+ * modules/fcntl (License): Likewise.
+
2010-12-10 Bruno Haible <br...@clisp.org>
Tests for module 'pipe-posix'.
diff --git i/modules/cloexec w/modules/cloexec
index 7fb7eeb..1267b7f 100644
--- i/modules/cloexec
+++ w/modules/cloexec
@@ -21,7 +21,7 @@ Include:
"cloexec.h"
License:
-LGPL
+LGPLv2+
Maintainer:
Jim Meyering, Eric Blake
diff --git i/modules/fcntl w/modules/fcntl
index addd6ba..67630f9 100644
--- i/modules/fcntl
+++ w/modules/fcntl
@@ -21,7 +21,7 @@ Include:
<fcntl.h>
License:
-LGPL
+LGPLv2+
Maintainer:
Eric Blake
--
Eric Blake ebl...@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
