On 13 Oct 2010, at 03:59, Bruno Haible wrote: >> * libposix/bootstrap: New script to import gnulib posix modules >> and bootstrap configury so that the result is an installable >> libposix.la. >> * libposix/configure.ac: New file to configure the new libposix >> subdirectory. >> * libposix/Makefile.am: New file to delegate build duties to the >> generated libposix/lib/Makefile at make time. >> * libposix/lib/Makefile.am: New file to make sure `-version-info' >> is passed to libtool at libposix.la link-time. > > This looks reasonable for a start. Additional files (for the version,
Taken care of by git-version-gen in [7/7] assuming that we can find a way to tag git revisions with appropriate libposix release numbers to feed it; > libtool version, Also taken care of in [7/7], pending addressing your feedback on that particular patch; > texinfo documentation, etc.) can come afterwards. ...plus README, NEWS and others to allow for removal of AM_INIT_AUTOMAKE foreign mode, and to allow for full GNU-like independent libposix release tarballs. > Just three remarks: > - It would be better to invoke 'posix-modules' from within 'bootstrap', > as mentioned in the reply to [PATCH 4/7]. I'm still unconvinced on this point. > - No tabs except where necessary, please. Agreed. Sorry about that. > - A 36-lines awk script inside a Makefile? Isn't it more maintainable to > put it in a separate file? Arguably. I have no strong feelings either way. Cheers, -- Gary V. Vaughan (g...@gnu.org)
PGP.sig
Description: This is a digitally signed message part
