Re: [PATCH] memmem, strstr, strcasestr: fix bug with long periodic needle

[Bruno Haible]

Hi Eric,

> - #if CYGWIN_VERSION_DLL_MAJOR >= 1007
> + #if CYGWIN_VERSION_DLL_MAJOR >= 1007 && CYGWIN_VERSION_DLL_MINOR > 7

I think this conditional expression will evaluate to false for
Cygwin 1.8.0, 1.9.5, and so on, which is not intended. The right
expression should be

  #if (CYGWIN_VERSION_DLL_MAJOR > 1007) || (CYGWIN_VERSION_DLL_MAJOR == 1007 && 
CYGWIN_VERSION_DLL_MINOR > 7)

or

  #if CYGWIN_VERSION_DLL_MAJOR * 1000 + CYGWIN_VERSION_DLL_MINOR > 1007007

There are 6 occurrences of this expression.

Bruno