Eric Blake wrote: > On 08/31/2010 08:11 AM, Eric Blake wrote: >> On 08/31/2010 02:10 AM, Jim Meyering wrote: >>> Eric, I've listed you as an author, so will wait for your ACK. >>> >>>> From 5bcff7b85b7b88fa4809ad874a1203e27abed085 Mon Sep 17 00:00:00 2001 >>> From: Eric Blake<ebl...@redhat.com> >>> Date: Tue, 31 Aug 2010 10:06:16 +0200 >>> Subject: [PATCH] hash: factor, and guard against misbehaving hasher >>> function >>> >>> * lib/hash.c (safe_hasher): New function, to encapsulate the checking >>> of table->hasher's return value. Also protect against a hash value >>> so large that adding it to table->bucket would result in a NULL pointer. >>> (hash_lookup, hash_get_next, hash_find_entry): Use it in place of >>> open-coded check-and-abort. >> >> ACK from me. > > Actually, you missed one function. I'm squashing this in, then pushing.
Glad you caught that. Thanks.