Hi Ian,
> Several of the unistr/u{8,16}-str* modules fail the test suite
> due to missing dependencies on unistr/u32-to-u{8,16}.
Indeed, I reproduce it.
> Patch attached.
> --- a/modules/unistr/u16-strchr
> +++ b/modules/unistr/u16-strchr
> @@ -7,6 +7,7 @@ lib/unistr/u16-strchr.c
> Depends-on:
> unistr/base
> unistr/u16-uctomb
> +unistr/u32-to-u16
>
> configure.ac:
> gl_LIBUNISTRING_MODULE([0.9], [unistr/u16-strchr])
Well, it's not the u16_strchr function which needs the u32_to_u16 function,
it's only its test:
gcc -g -O2 -o test-u16-strchr unistr/test-u16-strchr.o ../gllib/libgnu.a
unistr/test-u16-strchr.o: In function `test_strchr':
/tmp/testdir/gltests/unistr/test-strchr.h:45: undefined reference to
`u32_to_u16'
collect2: ld returned 1 exit status
make[4]: *** [test-u16-strchr] error 1
I'm therefore applying this fix. Thanks for the report!
2010-08-28 Bruno Haible <br...@clisp.org>
unistr/u*-strchr: Fix tests dependencies.
* modules/unistr/u8-strchr-tests (Depends-on): Add unistr/u32-to-u8.
* modules/unistr/u16-strchr-tests (Depends-on): Add unistr/u32-to-u16.
Reported by Ian Beckwith <i...@erislabs.net>.
--- modules/unistr/u8-strchr-tests.orig Sat Aug 28 22:35:13 2010
+++ modules/unistr/u8-strchr-tests Sat Aug 28 22:30:57 2010
@@ -10,6 +10,7 @@
getpagesize
unistr/u8-set
unistr/u32-set
+unistr/u32-to-u8
configure.ac:
gl_FUNC_MMAP_ANON
--- modules/unistr/u16-strchr-tests.orig Sat Aug 28 22:35:13 2010
+++ modules/unistr/u16-strchr-tests Sat Aug 28 22:30:57 2010
@@ -10,6 +10,7 @@
getpagesize
unistr/u16-set
unistr/u32-set
+unistr/u32-to-u16
configure.ac:
gl_FUNC_MMAP_ANON
