I just updated m4 to the latest gnulib, and it fails 'make syntax-check':

doc/m4.texinfo
maint.mk: out of date copyright in doc/m4.texi; update it
make: *** [sc_copyright_check] Error 1

Two bugs here:

First, m4.texinfo contains:

Copyright @copyright{} 1989, 1990, 1991, 1992, 1993, 1994, 2004, 2005,
2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.

Therefore, using the single-line checking of $(_sc_search_regexp) in
sc_copyright_check is doomed to false failures.

Second, notice that the file is named m4.texinfo, but the test is
hard-wired to only print an error for m4.texi.  Use of in_vc_files still
selects the longer spelling, because texi as a regular expression
matches texinfo, but it would be better to use the same approach as
sc_texinfo_acronym, as well as checking more than just $(PACKAGE).texi.

However, I'm not sure how best to rewrite the rule for multi-line
copyrights, so for now, I'm just skipping that check in m4.

-- 
Eric Blake   ebl...@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to