On 06/14/2010 01:56 PM, Bruno Haible wrote: >> Or even better, why not push those two tests upstream into autoconf, >> then have gnulib override AC_FUNC_STRTOD if it detects older autoconf, >> so that everyone using upstream AC_FUNC_STRTOD can reliably detect these >> same bugs? > > I don't think this would be better. The gnulib development of the last 7 years > has shown that the autoconf macro that detects bugs of a system function and > the replacement code that contains the workarounds to these bugs belong > together and are best maintained together. It makes no sense to me to put the > two files into different projects - autoconf and gnulib. > > At this point, it would be a good idea to mark all AC_FUNC_* macros that > request an AC_LIBOBJ replacement as obsolete and refer the user to Gnulib > for both the macro and the workaround code (and the documentation). > Except maybe AC_FUNC_MALLOC and AC_FUNC_REALLOC, because the replacement > code for them is so trivial that anyone can make it up himself.
Good argument. Are you able to write that patch soon, or should I tackle it? > The affected macros are: > - AC_FUNC_ERROR_AT_LINE > - AC_FUNC_GETLOADAVG > - AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK > - AC_FUNC_MEMCMP > - AC_FUNC_MKTIME > - AC_FUNC_OBSTACK > - AC_FUNC_STAT, AC_FUNC_LSTAT > - AC_FUNC_STRTOD > - AC_FUNC_STRNLEN > - AC_REPLACE_FNMATCH Looks like a reasonable list. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
