Ralf Wildenhues wrote:
> This one is *really* harmless (it'd require 'grep GNU' to cause an
> error), but the order of redirection does not do what was meant, so
> it should be flipped, or the 2>&1 omitted.  OK to apply?

Sure.  Thanks.

...
> -if ( diff --version < /dev/null 2>&1 | grep GNU ) 2>&1 > /dev/null; then
> +if ( diff --version < /dev/null 2>&1 | grep GNU ) > /dev/null 2>&1; then
>    compare() { diff -u "$@"; }
> -elif ( cmp --version < /dev/null 2>&1 | grep GNU ) 2>&1 > /dev/null; then
> +elif ( cmp --version < /dev/null 2>&1 | grep GNU ) > /dev/null 2>&1; then

Reply via email to