Ralf Wildenhues <[email protected]> writes: > Hi Simon, > > I like this patch, with one small nit: > > * Simon Josefsson wrote on Wed, May 19, 2010 at 08:41:29AM CEST: >> +This will run all self-checks under valgrind. This can be wasteful if >> +you have many shell scripts or other non-binaries. Using the Automake >> +parallel-tests feature, this can be avoided by using the following >> +instead: >> + >> +...@smallexample >> +AUTOMAKE_OPTIONS = parallel-tests >> +TEST_EXTENSIONS = .pl .sh >> +LOG_COMPILER = $(VALGRIND) >> +...@end smallexample >> + >> +Then valgrind will only be used for the non-.sh and non-.pl binaries. > > I'd write "tests" here instead of "binaries", that would be a tad more > precise. (The remaining tests may not all be binaries either.)
I made this change and pushed the patch. /Simon
