Simon Josefsson wrote: ... > Heh, easy to miss. > >> Please use the following: >> >> # Don't use Texinfo @acronym{} as it is not a good idea. >> texinfo_suffix_re_ ?= \\.(txi|texi(nfo)?)$$ >> sc_texinfo_acronym: >> @prohibit='@acronym\{' \ >> in_vc_files='$(texinfo_suffix_re_)' \ >> halt='found use of Texinfo @acronym{}' \ >> $(_sc_search_regexp) > > Thanks, committed and pushed now, in your name since you did all the > work here.
Thanks, but I guess you didn't test it any better than I did ;-) We want only one backslash before the ".": texinfo_suffix_re_ ?= \.(txi|texi(nfo)?)$$ >From 9b8f5e5c8eeaf11841536e6d6c82bd3ebaa52054 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Thu, 15 Apr 2010 13:50:16 +0200 Subject: [PATCH] maint.mk: texinfo_suffix_re_: correct the default regexp * top/maint.mk (texinfo_suffix_re_): Fix default regexp. --- ChangeLog | 3 +++ top/maint.mk | 2 +- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index ccc17d9..7098e41 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2010-04-15 Jim Meyering <meyer...@redhat.com> + maint.mk: texinfo_suffix_re_: correct the default regexp + * top/maint.mk (texinfo_suffix_re_): Fix default regexp. + * top/maint.mk (sc_texinfo_acronym): Improve filename regexp, and make it configurable via texinfo_suffix_re_. diff --git a/top/maint.mk b/top/maint.mk index 4d87b4a..cb8461c 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -660,7 +660,7 @@ sc_GFDL_version: $(_sc_search_regexp) # Don't use Texinfo @acronym{} as it is not a good idea. -texinfo_suffix_re_ ?= \\.(txi|texi(nfo)?)$$ +texinfo_suffix_re_ ?= \.(txi|texi(nfo)?)$$ sc_texinfo_acronym: @prohibit='@acronym\{' \ in_vc_files='$(texinfo_suffix_re_)' \ -- 1.7.1.rc1.248.gcefbb