Javier Villavicencio wrote: > I think you may have mixed up the two patches I reported against grep
Think again ;-) > bug 29358, so, to clarify: > That above is actually the patch that made most sense to me against the > EXCLUDE_INCLUDE logic, as in: excluded_file_pattern_p should return > !excluded on string match, not depending on the value excluded gets from > options. > > The fix for GLOB matching is the second patch to grep's main.c, that > just adds the EXCLUDE_WILDCARDS option to add_exclude(). Both are required. If we don't use exclude_fnmatch properly, then --include=GLOB doesn't work. If we don't specify EXCLUDE_WILDCARDS, then grep doesn't even call exclude_fnmatch.
