On 03/23/2010 01:34 AM, Bert Wesarg wrote: >> + * lib/glob.c (glob): Lose register modifier. Drop redundant >> + code. >> glob (pattern, flags, errfunc, pglob) >> - const char * restrict pattern; >> + const char *pattern; > > Thats 'restrict' not 'register'.
Hmm. I wasn't reading that very well, then. The change would synchronize gnulib and glibc (since glibc also lacks the restrict modifier), but keeping the modifier might help the compiler, and is certainly more POSIX compliant. On the other hand, the fact that the declaration is still K&R style makes me cringe, but again it is a matter of glibc synchronization. I think I'll just revert this part of the hunk. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
