On 03/08/2010 11:34 AM, Sam Steingold wrote: > Sam Steingold wrote: >> >> Alternatively, I would be reasonably happy with >> sed -i -e 's/_GL_ARG_NONNULL/GL_ARG_NONNULL/' arg-nonnull.h >> sed -i -e 's/_GL_WARN_ON_USE/GL_WARN_ON_USE/' warn-on-use.h >> similar to GL_LINK_WARNING in link-warning.h. > > So, any chance the constants in arg-nonnull.h & warn-on-use.h could be > renamed to lose the leading underscore? > note that the only other build-aux header, link-warning.h, defines > macros _without_ the leading underscore, so it seems to make sense for > the new headers in build-aux to lose the leading underscore too.
I'm still hoping Bruno will step in and help in this thread. link-warning.h was created first, before we realized that the use of a leading GL_ might lead to conflicts with other packages. The use of a leading _GL_ is intended to mark items that are specifically in gnulib's namespace. As to whether the template files live in build-aux or get moved to lib, Bruno needs to answer why link-warning.h was originally stuck in build-aux rather than lib. For arg-nonnull and warn-on-use, they are just following precedent. If we do any motion, all three files should be handled the same way. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
