Hi Eric,
* Eric Blake wrote on Wed, Jan 06, 2010 at 10:04:08PM CET:
> Ralf Wildenhues writes:
>
> > I remember the fts-lgpl module already being broken last time I tested
> > gnulib. Does anyone use this module at all, and how come they don't see
> > this issue?
>
> I think you've nailed it - fts-lgpl isn't really being used anywhere.
> We originally offered it as a way to port glibc's fts to platforms
> that lacked fts altogether, but glibc's fts is so much worse than
> gnulib's that it hasn't been worth trying to maintain. Maybe we
> should just delete the module, and require GPL? Or maybe someone can
> provide a better argument why library-safe directory recursion is
> still an important goal, even if it is slower because it can't rely on
> openat optimizations.
No further comments on this so far, so I'll propose this patch.
Cheers,
Ralf
Remove fts-lgpl module.
* modules/fts-lgpl: Remove.
* MODULES.html.sh (func_all_modules): Adjust.
* check-module (find_included_lib_files): Adjust.
* m4/fts.m4 (gl_FUNC_FTS_LGPL): Remove.
diff --git a/MODULES.html.sh b/MODULES.html.sh
index e3602ef..dc09805 100755
--- a/MODULES.html.sh
+++ b/MODULES.html.sh
@@ -2477,7 +2477,6 @@ func_all_modules ()
func_module filenamecat
func_module filenamecat-lgpl
func_module fts
- func_module fts-lgpl
func_module isdir
func_module lchmod
func_module lchown
diff --git a/check-module b/check-module
index af42b1e..eaf00fb 100755
--- a/check-module
+++ b/check-module
@@ -228,10 +228,6 @@ my %exempt_header =
'lib/gc-gnulib.c:rijndael-api-fst.h' => 1,
'lib/gc-gnulib.c:hmac.h' => 1,
'lib/gc-libgcrypt.c:md2.h' => 1,
-
- # The fts-lgpl module doesn't actually use fts-cycle.c and unistd-safer.h.
- 'lib/fts.c:fts-cycle.c' => 1,
- 'lib/fts.c:unistd-safer.h' => 1,
);
sub check_module ($)
diff --git a/m4/fts.m4 b/m4/fts.m4
index c40f085..4a4a21e 100644
--- a/m4/fts.m4
+++ b/m4/fts.m4
@@ -1,4 +1,4 @@
-#serial 17
+#serial 18
dnl Copyright (C) 2005-2010 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -9,11 +9,6 @@ AC_DEFUN([gl_FUNC_FTS],
gl_FUNC_FTS_CORE
])
-AC_DEFUN([gl_FUNC_FTS_LGPL],
-[
- gl_FUNC_FTS_CORE
-])
-
AC_DEFUN([gl_FUNC_FTS_CORE],
[
dnl Use this version of fts unconditionally, since the GNU libc and
diff --git a/modules/fts-lgpl b/modules/fts-lgpl
deleted file mode 100644
index 3a6f0ed..0000000
--- a/modules/fts-lgpl
+++ /dev/null
@@ -1,28 +0,0 @@
-Description:
-Traverse a file hierarchy (LPGL'ed version).
-
-Files:
-lib/fts_.h
-lib/fts.c
-m4/fts.m4
-
-Depends-on:
-dirfd
-fchdir
-i-ring
-openat
-stdbool
-
-configure.ac:
-gl_FUNC_FTS_LGPL
-
-Makefile.am:
-
-Include:
-"fts_.h"
-
-License:
-LGPL
-
-Maintainer:
-Jim Meyering
