Eric Blake wrote:
> According to Bruno Haible on 12/26/2009 11:59 AM:
> > * The dependency of dup2-tests on 'cloexec' could be removed if the
> > relevant (small) part of the test would be enclosed in
> > #ifdef GNULIB_CLOEXEC
> > so that it is skipped if the cloexec module is not present. coreutils
> > does include the 'cloexec' module, therefore at least the coreutils users
> > will still have a 100% check of dup2.
>
> Seems reasonable. I'll push this.
Thanks. This is precisely what I had in mind too.
> > * The dependency of dup2-tests on 'open' can safely be removed because the
> > file to be opened is "test-dup2.tmp", which does not trigger any of the
> > problems listed in doc/posix-functions/open.texi.
>
> No, the test also does 'open ("/dev/null",...)', which _does_ require the
> open module.
Oops, you're right. Yes.
Bruno
