Eric Blake <e...@byu.net> ha escrit: > Who do we use as --author and/or reporter in the git commit? The patch > first> appeared on the tar list in an email by Solar Designer, but it is not > clear > whether he wrote it, or whether we should attribute yet some other > person.
It was reported by Solar Designer <so...@openwall.com>. I don't know whether it was him who wrote the patch, but (I guess) that would be relevant only if we really planned to accept the patch as is. The variant you proposed looks much better, in my opinion. > Quite wasteful. Rather than calling strlen and redoing an O(n) walk of the [...] > For that matter, the temporary variable actual_size is not even needed. I'd > write the patch as just a 2-line addition: Agreed. What I was asking about was not the patch itself, but the idea behind it. Regards, Sergey
