Jim Meyering <jim <at> meyering.net> writes:

> +  off_t old_offset = __libc_lseek (fd, 0, SEEK_CUR);

> +Depends-on:
> +unistd
> +

Needs to depend on lseek, particularly since pread is replaced on mingw, and 
mingw has an lseek bug with non-seekable files (like pipes).

Perhaps test-pread.sh should also check that pread fails with ESPIPE on a non-
seekable fd?  Also, the test should probably cover EINVAL for trying to read 
negative offsets.

-- 
Eric Blake





Reply via email to