Jim Meyering <jim <at> meyering.net> writes:
> #!/bin/sh
> : ${srcdir=.} ${builddir=.}
According to the autoconf manual, $builddir is rigourously equal to '.', from
within autoconf-generated files (such as Makefile built from Makefile.in). I
can see keeping this line so that you can run the script by hand from some
other directory after the fact...
> +TESTS_ENVIRONMENT += \
> + srcdir='$(srcdir)' \
> + builddir='$(builddir)'
...but since builddir is constant within the Makefile, then why do we need to
bother passing it via TESTS_ENVIRONMENT? I could, however, see the potential
use of $(abs_builddir).
> create mode 100644 tests/test-pread.sh
Oops; this needs an executable bit.
> +: ${srcdir=.} ${builddir=.}
> +. $srcdir/init.sh --set-path=$builddir
> +
> +fail=0;
Should we hoist fail=0 into init.sh, as was done in coreutils?
--
Eric Blake
