-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I'm considering using manywarnings in m4, and noticed that newer gcc supports even more warnings. I noticed several warnings supported by gcc 4.3.4 --help=warnings that were not listed already; see the patch below. However, looking at it closer, it is obvious that some of the newly-added warnings added in this patch are C++ or ObjC-specific; maybe we should break this macro into the set of warnings useful for each language, rather than an overall list. For that matter, some warnings (like -Wtraditional) don't make any sense in the context of gnulib, since we require C89 or better, so including them in gl_MANYWARN_ALL_GCC just means that package maintainers have to exclude it.
- -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkr1qSIACgkQ84KuGfSFAYCX4ACdGxs5x3RcwGQHITNvS6O6D2xY GJwAniJ3QUml29qPD25T9JFQEF7BkmN8 =pr3l -----END PGP SIGNATURE-----
>From ca4ea613b2ab99550535db14ca0363a12228a449 Mon Sep 17 00:00:00 2001 From: Eric Blake <e...@byu.net> Date: Fri, 6 Nov 2009 12:16:10 -0700 Subject: [PATCH] manywarnings: add more warnings * modules/manywarnings (Depends-on): Add warnings. * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add warnings from gcc 4.3.4. Signed-off-by: Eric Blake <e...@byu.net> --- ChangeLog | 7 +++++ m4/manywarnings.m4 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++- modules/manywarnings | 1 + 3 files changed, 80 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 997a759..395ca5b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2009-11-07 Eric Blake <e...@byu.net> + + manywarnings: add more warnings + * modules/manywarnings (Depends-on): Add warnings. + * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add warnings from gcc + 4.3.4. + 2009-11-06 Simon Josefsson <si...@josefsson.org> * modules/memchr (Depends-on): Drop getpagesize dependency. diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4 index 7f36fb4..65421ef 100644 --- a/m4/manywarnings.m4 +++ b/m4/manywarnings.m4 @@ -1,4 +1,4 @@ -# manywarnings.m4 serial 1 +# manywarnings.m4 serial 2 dnl Copyright (C) 2008, 2009 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -97,10 +97,81 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC], # The following are not documented in the manual but are included in # output from gcc --help=warnings. for gl_manywarn_item in \ + -Wabi \ + -Waddress \ + -Waliasing \ + -Wampersand \ + -Wassign-intercept \ + -Warray-bounds \ -Wattributes \ + -Wc++0x-compat \ -Wcoverage-mismatch \ + -Wchar-subscripts \ + -Wcharacter-truncation \ + -Wclobbered \ + -Wcomment \ + -Wctor-dtor-privacy \ + -Wdeprecated \ + -Wdeprecated-declarations \ + -Wdiv-by-zero \ + -Weffc++ \ + -Wempty-body \ + -Wendif-labels \ + -Wformat \ + -Wformat-contains-nul \ + -Wformat-extra-args \ + -Wformat-zero-length \ + -Wignored-qualifiers \ + -Wimplicit-function-declaration \ + -Wimplicit-int \ + -Wimplicit-interface \ + -Wint-to-pointer-cast \ + -Winvalid-offsetof \ + -Wline-truncation \ + -Wmain \ + -Wmissing-braces \ + -Wmissing-field-initializers \ + -Wmissing-parameter-type \ -Wmultichar \ + -Wnon-template-friend \ + -Wnon-virtual-dtor \ + -Wnonnull \ + -Wnonstd-intrinsics \ + -Wold-style-cast \ + -Wold-style-declaration \ + -Woverflow \ + -Woverloaded-virtual \ + -Woverride-init \ + -Wparentheses \ + -Wpmf-conversions \ + -Wpointer-sign \ + -Wpointer-to-int-cast \ + -Wpragmas \ + -Wprotocol \ + -Wreorder \ + -Wreturn-type \ + -Wselector \ + -Wsequence-point \ + -Wsign-compare \ + -Wsign-promo \ + -Wstrict-null-sentinel \ + -Wstrict-selector-match \ + -Wsurprising \ + -Wswitch \ + -Wsynth \ + -Wtabs \ + -Wtrigraphs \ + -Wtype-limits \ + -Wundeclared-selector \ + -Wunderflow \ + -Wuninitialized \ + -Wunused-function \ + -Wunused-label \ -Wunused-macros \ + -Wunused-parameter \ + -Wunused-value \ + -Wunused-variable \ + -Wvariadic-macros \ ; do gl_manywarn_set="$gl_manywarn_set $gl_manywarn_item" done diff --git a/modules/manywarnings b/modules/manywarnings index fae9221..f557ef0 100644 --- a/modules/manywarnings +++ b/modules/manywarnings @@ -5,6 +5,7 @@ Files: m4/manywarnings.m4 Depends-on: +warnings configure.ac: -- 1.6.5.rc1