Eric Blake wrote: > Jim Meyering <jim <at> meyering.net> writes: > >> > Based on Jim's preliminary review, I've now pushed this series. >> >> I tried it with coreutils on fedora rawhide and hit a compile >> failure (SIZE_MAX, again). Also fixed the first-line summary >> to mention the right file and function names. >> >> I fixed it the same way as for linkat. >> If you prefer simply adding a SIZE_MAX definition, >> you're welcome to do that instead. > > How about this followup. > >>From 2c479d06f3fa8d97e22ce8eb46f14990fde2ce12 Mon Sep 17 00:00:00 2001 > From: Eric Blake <e...@byu.net> > Date: Thu, 8 Oct 2009 10:09:05 -0600 > Subject: [PATCH] areadlink: make SIZE_T use consistent
s/SIZE_T/SIZE_MAX/ > * modules/areadlink (Depends-on): Add stdint. > * modules/areadlink-with-size (Depends-on): Likewise. > * lib/areadlink.c (includes): Update list of headers. > (SIZE_MAX): Rely on headers. > * lib/areadlink-with-size.c (includes, SIZE_MAX): Likewise. > * lib/areadlinkat-with-size.c (includes): Likewise. Adding the dependency on stdint is fine with me. Removing inclusion of stdio.h is great if really you can do that -- I didn't check. But please mention it in the ChangeLog and justify it, if it's not obvious.
