Ian Beckwith <ianb <at> erislabs.net> writes: > > Hi, > > More test-suite problems: > > Missing dependencies (trivial patches attached): > > gnumakefile: maintainer-makefile
Wrong. maintainer-makefile already depends on gnumakefile, so adding this dependency would create a circular dependency. Rather, we need to figure out how to make gnumakefile work gracefully when maintainer-makefile is not in use. > > fts-lgpl: cloexec fcntl-safer dirent-safer Wrong. This has been a can of worms. All three of those dependencies are GPL, so fts-lgpl can't depend on them. The correct fix is to instead modify the sources to do conditional includes based on whether GNULIB_CLOEXEC and friends are defined, rather than adding yet another GPL module dependency. For what it's worth, fts-lgpl has been somewhat neglected in favor of GPL fts. Also, I've been meaning to split dirname into dirname-lgpl, so that several modules (argp, fts-lgpl, rename, ...) can use dirname.h and the non-xalloc_die functions without dragging in GPL code. > With ./gnulib-tool --create-megatestdir --with-tests, > fseek fails to compile when combined in ALL/ with any of: > fwritable fwritable-tests or fwriting. Previously reported. Thanks for further clarifying some of the details. I still haven't had time to figure out how to fix it, but fixing it is still on my TODO list. -- Eric Blake
