Eric Blake wrote:
...
> Also, we need this, to pick up the change in .h file:
>
...
> Subject: [PATCH] canonicalize-lgpl: adjust clients to use correct header
>
...
> * lib/fchdir.c (includes): Use <stdlib.h>, not "canonicalize.h".
Looks good.
Along that line, I've added this:
>From 27fc6b8b3c176038ff7216a6af6dfba82de17537 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyer...@redhat.com>
Date: Sat, 19 Sep 2009 19:51:05 +0200
Subject: [PATCH] syntax-check: detect unnecessary inclusion of canonicalize.h
* top/maint.mk (sc_prohibit_canonicalize_without_use): New rule.
---
ChangeLog | 5 +++++
top/maint.mk | 5 +++++
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 68321e9..fab0733 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-09-19 Jim Meyering <meyer...@redhat.com>
+
+ syntax-check: detect unnecessary inclusion of canonicalize.h
+ * top/maint.mk (sc_prohibit_canonicalize_without_use): New rule.
+
2009-09-19 Eric Blake <e...@byu.net>
canonicalize-lgpl: adjust clients to use correct header
diff --git a/top/maint.mk b/top/maint.mk
index c0c3f27..fe6b3ff 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -288,6 +288,11 @@ sc_prohibit_argmatch_without_use:
re='(\<(ARRAY_CARDINALITY|X?ARGMATCH(|_TO_ARGUMENT|_VERIFY))\>|\<argmatch(_exit_fn|_(in)?valid)
*\()' \
$(_header_without_use)
+sc_prohibit_canonicalize_without_use:
+ @h='"canonicalize.h"' \
+
re='CAN_(EXISTING|ALL_BUT_LAST|MISSING)|canonicalize_(mode_t|filename_mode)' \
+ $(_header_without_use)
+
sc_prohibit_root_dev_ino_without_use:
@h='"root-dev-ino.h"' \
re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \
--
1.6.5.rc1.192.g63b0
