Eric Blake wrote:

> Jim Meyering <jim <at> meyering.net> writes:
>
>> > Meanwhile, the rmdir-errno module, in use by coreutils until today, guessed
>> > wrong for cross-compilation to Solaris (where rmdir fails with EEXIST, not
>> > ENOTEMPTY, on a populated directory); now that coreutils no longer uses the
>> > module [1], I see no reason to keep the module alive.
>>
>> I was thinking of marking it as obsolete,
>> (AFAIK, there's been no actual problem report)
>> but if coreutils was the only user, deleting should be ok.
>
> OK, I'll be nice, as obsoletion gives a bit longer transition phase if anyone
> else was using rmdir-errno.  Also, I added a test of unlinkat, to make sure
> that rmdir bugs don't reappear.  Path [1/2] of the previous mail is unchanged,
> but here's what replaces [2/2] and a new [3/2]:

All of this looks fine, too.
It's great to have so many and thorough tests.
Thanks!


Reply via email to