Hi Simon, I noticed some long lines and unnecessary '&&' between statements in the refresh-po rule so made a few changes. I'm pretty sure I've introduced no semantic change.
>From adbc54c3a6c917941c845fccc557a83c46f130d4 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyer...@redhat.com> Date: Tue, 4 Aug 2009 10:22:16 +0200 Subject: [PATCH] maint.mk: clean up refresh-po * top/maint.mk (refresh-po): Remove several unnecessary "&& \". Split long lines. Consolidate two sed commands. Use printf rather than a pair of echo stmts. --- ChangeLog | 6 ++++++ top/maint.mk | 15 +++++++++------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1eacff5..1ec42cc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2009-08-04 Jim Meyering <meyer...@redhat.com> + maint.mk: clean up + * top/maint.mk (refresh-po): Remove several unnecessary "&& \". + Split long lines. + Consolidate two sed commands. + Use printf rather than a pair of echo stmts. + maint.mk: add a copyright-updating rule * top/maint.mk (update-copyright): New rule. Derived from coreutils/Makefile.am. diff --git a/top/maint.mk b/top/maint.mk index 2db44ba..8c0294b 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -760,12 +760,15 @@ PO_DOMAIN ?= $(PACKAGE) POURL = http://translationproject.org/latest/$(PO_DOMAIN)/ PODIR ?= po refresh-po: - rm -f $(PODIR)/*.po && \ - echo "$(ME): getting translations into po (please ignore the robots.txt ERROR 404)..." && \ - wget --no-verbose --directory-prefix $(PODIR) --no-directories --recursive --level 1 --accept .po --accept .po.1 $(POURL) && \ - echo 'e...@boldquot' > $(PODIR)/LINGUAS && \ - echo 'e...@quot' >> $(PODIR)/LINGUAS && \ - ls $(PODIR)/*.po | sed 's/\.po//' | sed 's,$(PODIR)/,,' | sort >> $(PODIR)/LINGUAS + rm -f $(PODIR)/*.po + echo '$(ME): getting translations into po' \ + '(please ignore the robots.txt ERROR 404)...' + wget --no-verbose --directory-prefix $(PODIR) --no-directories \ + --recursive --level 1 --accept .po --accept .po.1 $(POURL) + printf 'e...@boldquot\nen@quot\n' > $(PODIR)/LINGUAS + ls $(PODIR)/*.po \ + | sed 's/\.po//;s,$(PODIR)/,,' \ + | sort >> $(PODIR)/LINGUAS INDENT_SOURCES ?= $(C_SOURCES) .PHONY: indent -- 1.6.4.70.g9c084